Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ResizableContainer #752

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat: ResizableContainer #752

wants to merge 30 commits into from
+620 −15

Conversation

marc2332
Copy link
Owner

Closes #670

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.34483% with 34 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (9ac867e) to head (b383a58).

Files with missing lines Patch % Lines
crates/components/src/resizable_container.rs 91.66% 18 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 16 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           feat/flex     #752      +/-   ##
=============================================
+ Coverage      74.33%   74.55%   +0.21%     
=============================================
  Files            214      215       +1     
  Lines          24730    24947     +217     
=============================================
+ Hits           18384    18599     +215     
- Misses          6346     6348       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 mentioned this pull request Sep 6, 2024
Open
@marc2332 marc2332 marked this pull request as ready for review September 11, 2024 13:28
@marc2332 marc2332 changed the base branch from main to feat/flex September 26, 2024 19:25
@github-actions GitHub Actions
Copy link

Benchmark for 81f64cc

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 103.3±0.38ms 107.6±0.60ms +4.16%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.5±0.42ms 24.6±1.01ms +4.68%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1359.5±16.15µs 1422.1±41.97µs +4.60%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.2±0.96µs 138.8±1.34µs +4.99%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.7±0.28ms 24.2±0.26ms +2.11%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1668.1±22.28µs 1734.9±11.53µs +4.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 311.9±2.84µs 315.5±4.62µs +1.15%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.01ms 2.7±0.08ms +8.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 409.6±124.06µs 423.4±78.91µs +3.37%
benchmarks/size=54241 depth=5 wide=15 mode=cached 252.2±9.26µs 252.1±11.37µs -0.04%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.09ms 6.6±0.09ms +6.45%

@marc2332 marc2332 marked this pull request as draft September 28, 2024 15:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Benchmark for 5ffc401

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 111.0±0.85ms 112.1±1.63ms +0.99%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 27.6±1.16ms 27.5±1.00ms -0.36%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1583.2±17.27µs 1490.4±19.93µs -5.86%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 153.4±2.05µs 142.5±1.41µs -7.11%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.2±0.90ms 26.8±0.99ms +2.29%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1825.0±105.64µs 1807.2±31.21µs -0.98%
benchmarks/size=19531 depth=7 wide=5 mode=cached 322.6±14.00µs 353.2±20.79µs +9.49%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.07ms 2.8±0.11ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 430.7±12.42µs 433.2±85.68µs +0.58%
benchmarks/size=54241 depth=5 wide=15 mode=cached 311.3±53.59µs 271.5±40.79µs -12.79%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.9±0.20ms 7.0±0.37ms +1.45%

Base automatically changed from feat/flex to main November 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement 🔥 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: ResizableContainer component
1 participant
@marc2332